Merged
Conversation
LordSimal
force-pushed
the
6.x-remove-underscore-from-methods
branch
2 times, most recently
from
3094cfe to
9a6d52f
Compare
LordSimal
force-pushed
the
6.x-remove-underscore-from-methods
branch
from
9a6d52f to
5026929
Compare
LordSimal
commented
May 29, 2025
LordSimal
force-pushed
the
6.x-remove-underscore-from-methods
branch
from
8f5b45c to
3d75cf2
Compare
LordSimal
commented
May 30, 2025
| } | ||
| $process = Process::fromShellCommandline($command); | ||
| $process->setEnv($_ENV); | ||
| $process->setTimeout(null); |
Contributor
Author
There was a problem hiding this comment.
The symfony process utility has a default 60 second timeout for commands it runs. Since it can take way longer for rector to finish this is the best way to go.
LordSimal
commented
May 30, 2025
composer.json
Outdated
| "cakephp/console": "^5.1.5", | ||
| "nette/utils": "^4.0", | ||
| "rector/rector": "dev-main", | ||
| "symfony/process": "^5.4|^6.0|^7.0", |
Contributor
Author
There was a problem hiding this comment.
I guess we can drop 5.4 here since cake 5 requires php 8+
markstory
approved these changes
May 31, 2025
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
I think if we're going to do these kinds of refactors this is the best way to do it.
| return static::CODE_ERROR; | ||
| } | ||
| $io->success('Rector applied successfully'); | ||
| $io->success('🎉 Upgrade complete! 🎉'); |
| 'Cake\View\Widget\RadioWidget' => ['_renderInput', '_renderLabel', '_isDisabled'], | ||
| 'Cake\View\Widget\CheckboxWidget' => ['_isChecked'], | ||
| 'Cake\View\Widget\WidgetLocator' => ['_resolveWidget'], | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
I hope you now understand why i want to make these changes 😁
LordSimal
added a commit
that referenced
this pull request
Jan 6, 2026
* remove underscores from collection package methods via rector * remove underscores from command package methods via rector * remove underscores from console package methods via rector * remove underscores from controller package methods via rector * remove underscores from core package methods via rector * refactor static return type config * re-add trait methods for cake6 config * adjust SimpleStaticType config * remove underscores from database package methods via rector * remove underscores from datasource package methods via rector * remove underscores from error package methods via rector * remove underscores from event package methods via rector * remove underscores from form package methods via rector * remove underscores from http package methods via rector * remove underscores from I18N package methods via rector * remove underscores from Log package methods via rector * remove underscores from mailer package methods via rector * remove underscores from network package methods via rector * remove underscores from orm package methods via rector * remove underscores from routing package methods via rector * remove underscores from testsuite package methods via rector * remove underscores from utility package methods via rector * remove underscores from validation package methods via rector * remove underscores from view package methods via rector * add symfony process as a command wrapper for rector * fix tests with wrong assumptions about --dry-run rector exit codes * use tagged version of rector * adjust symfony/process dependency range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #309